-
Notifications
You must be signed in to change notification settings - Fork 220
Specify null safety subtyping #3515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
082c391
to
a9f4886
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't really review this as source.
Do we still have a way to generate a rendering showing the changes?
a9f4886
to
0fd9980
Compare
0fd9980
to
84e6d38
Compare
84e6d38
to
4fcf76e
Compare
4fcf76e
to
b7cdb30
Compare
b7cdb30
to
bf98431
Compare
Based on the output from Front matterOnly comments. @@ -21633,128 +21631,188 @@Section 'Subtypes': Now mentions intersection types. Figure 'Subtype rules': Changed a lot. Subsection 'Meta-Variables': Slightly changes presentation of Subsection 'Subtype Rules': Introduces the 'canonical syntax' of a Subsection 'Being a Subtype': Extensively rewritten. Subsubsection 'Informal subtype rule descriptions': Rewritten extensively. Subsection 'Additional Subtyping Concepts': Extensively rewritten. Section 'Function Types': Last paragraph modified. Section 'Type Function': Rewritten. @@ -22482,7 +22498,7 @@Just the title of section 'Type dynamic' was adjusted, for consistency Section 'Type FutureOr': Just adding missing Section 'Type void': Removed commentary that reiterated an obsolete Subsection 'Void Soundness': Example updated, plus body text about the @@ -23324,156 +23324,238 @@Section 'Appendix: Algorithmic Subtyping': Updated to use the |
I tried to use |
I added a section about 'being the same type', and adjusted the text such that the thing previously known as 'canonical syntax' (now renamed to 'explicitly resolved syntax') is encapsulated in this section. Also, alpha equivalence has been made part of this 'being the same type' section. |
54323ec
to
d02466b
Compare
23b26ca
to
70aafbc
Compare
70aafbc
to
249579f
Compare
24efd03
to
27f972b
Compare
This PR contains the null-safety updates from #2605 (the overall null-safety PR) that are concerned with subtyping. The intention is that we process and land this PR, and #2605 will then be made smaller when it is rebased over this one, thus allowing us to deal with the null-safety update in smaller portions.